Make shellcheck cover our .source files
#3660
Merged
+24
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and fix them so it passes. This is to avoid issues such as #3650 [static] I tried tweaking `.pre-commit-config.yaml` instead but it didn't quite work / ended up way too complex. With only two affected files, adding a line on top and adding `+x` seems like a reasonable workaround... Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
isegall-da
approved these changes
Jan 22, 2026
Contributor
isegall-da
left a comment
isegall-da
left a comment
There was a problem hiding this comment.
Thanks!
Make shellcheck cover our .source files
This is done simply by adding the #!/usr/bin/env bash at the top? That's what shellcheck uses to determine what to look at? (because I don't see any change to some regex or something that would otherwise do that in the PR)
Contributor
Author
That and I find it slightly hacky (especially the mode change), but the alternatives I came up with were less great... |
Contributor
Ah, I missed that part. Ugly as hell, but if it works... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and fix them so it passes.
This is to avoid issues such as #3650
[static]
I tried tweaking
.pre-commit-config.yamlinstead but it didn't quite work / ended up way too complex.With only two affected files, adding a line on top and adding
+xseems like a reasonable workaround...Signed-off-by: Martin Florian martin.florian@digitalasset.com